Pokemon

[jradich]

Ok so what I decided to make was a very simple version of the Pokemon battle system. There's no AI at the moment, and there is certainly a lot to be implemented, but I think it's a good start. Enjoy!
And excuse inappropriate names.

[Roland_Yonaba]

This is definitely not a good start.
I looked at it, and found many code repetitions. That is not how classes work.
Besides, you are using a fairly simple class system.Then take full advantage of it.

Note that yours classes (Twattle and Vagikarp) have exactly the same methods, but you repeated them. I expect when you'll next have to add new species, you will rewrite down the same stuff, and it will result in a extremely long source code.

Why not move all methods (draw, fight, level up, faint) into the basePoke class ? And then instanciate Vagikarp and Twattle ?

Code: Select all

class "BasePoke" {
	hp=100, name="Base",user=true,enemy=false,level=1,attacking=false,attackname='fap'
}
function BasePoke:__init(hp,name,user,enemy,level,attacking,attackname)--Sets how you would name a custom pokemon
  --etc
end


function BasePoke:draw()
  --etc
end
function BasePoke:fight()
  --etc
end

function BasePoke:levelup()
  --etc
end

function BasePoke:faint()
  --etc
end

Vagikarp=BasePoke:new(100,"Vagikarp",true,false,1,false,'fap')
Twattle=BasePoke:new(100,"Twattle",false,true,1,false,'fap')

And that's it. Then you should be able to use Twattle:draw(), Vagikarp:levelup(), etc...the same way than before.
Don't forget to consider that inside methods, you can call other methods, just use self.
Example:

Code: Select all

function BasePoke:fight()
	if fight==true then
        --etc etc
	end
	self:levelup()
	--etc etc
end

[jradich]

This is definitely not a good start.
I looked at it, and found many code repetitions. That is not how classes work.
Besides, you are using a fairly simple class system.Then take full advantage of it.

Note that yours classes (Twattle and Vagikarp) have exactly the same methods, but you repeated them. I expect when you'll next have to add new species, you will rewrite down the same stuff, and it will result in a extremely long source code.

Why not move all methods (draw, fight, level up, faint) into the basePoke class ? And then instanciate Vagikarp and Twattle ?

Code: Select all

class "BasePoke" {
	hp=100, name="Base",user=true,enemy=false,level=1,attacking=false,attackname='fap'
}
function BasePoke:__init(hp,name,user,enemy,level,attacking,attackname)--Sets how you would name a custom pokemon
  --etc
end


function BasePoke:draw()
  --etc
end
function BasePoke:fight()
  --etc
end

function BasePoke:levelup()
  --etc
end

function BasePoke:faint()
  --etc
end

Vagikarp=BasePoke:new(100,"Vagikarp",true,false,1,false,'fap')
Twattle=BasePoke:new(100,"Twattle",false,true,1,false,'fap')

And that's it. Then you should be able to use Twattle:draw(), Vagikarp:levelup(), etc...the same way than before.
Don't forget to consider that inside methods, you can call other methods, just use self.
Example:

Code: Select all

function BasePoke:fight()
	if fight==true then
        --etc etc
	end
	self:levelup()
	--etc etc
end

Thanks
Changed it.

love pokemon.love

(2.5 KiB) Downloaded 377 times

[rokit boy]

This is definitely not a good start.
I looked at it, and found many code repetitions. That is not how classes work.
Besides, you are using a fairly simple class system.Then take full advantage of it.

Note that yours classes (Twattle and Vagikarp) have exactly the same methods, but you repeated them. I expect when you'll next have to add new species, you will rewrite down the same stuff, and it will result in a extremely long source code.

Why not move all methods (draw, fight, level up, faint) into the basePoke class ? And then instanciate Vagikarp and Twattle ?

Code: Select all

class "BasePoke" {
	hp=100, name="Base",user=true,enemy=false,level=1,attacking=false,attackname='fap'
}
function BasePoke:__init(hp,name,user,enemy,level,attacking,attackname)--Sets how you would name a custom pokemon
  --etc
end


function BasePoke:draw()
  --etc
end
function BasePoke:fight()
  --etc
end

function BasePoke:levelup()
  --etc
end

function BasePoke:faint()
  --etc
end

Vagikarp=BasePoke:new(100,"Vagikarp",true,false,1,false,'fap')
Twattle=BasePoke:new(100,"Twattle",false,true,1,false,'fap')

And that's it. Then you should be able to use Twattle:draw(), Vagikarp:levelup(), etc...the same way than before.
Don't forget to consider that inside methods, you can call other methods, just use self.
Example:

Code: Select all

function BasePoke:fight()
	if fight==true then
        --etc etc
	end
	self:levelup()
	--etc etc
end

Thanks
Changed it.

love pokemon.love

addthat to SYS post.

[jradich]

addthat to SYS post.

Already did.

[misstr87]

Some good basic advice there for beginners.
Thanks.

And hope the pokemon project continues

[jradich]

love pokemon.zip

(4.78 KiB) Downloaded 310 times

New Update. Pictures are now possible, and there are multiple attacks.

[Roland_Yonaba]

I haven't run it yet, I just took a look at the code. Looks nicer than before.

[jradich]

I haven't run it yet, I just took a look at the code. Looks nicer than before.

Thanks.
Oh and also, making pokemon is incredibly easy. Just write:

Code: Select all

YourPoke=BasePoke:new(hp,name,user,enemy,level,attackname1,attackname2,pic)

And call "YourPoke:fight()" and "YourPoke:draw()" in the proper functions. Remember, though, there are only two attacks, though new attacks are easy, too.

[jradich]

love pokemon.love

(20.17 KiB) Downloaded 505 times

Shameless bump, because of progress.