11.0 bugs

General discussion about LÖVE, Lua, game development, puns, and unicorns.
User avatar
pgimeno
Party member
Posts: 1229
Joined: Sun Oct 18, 2015 2:58 pm

11.0 bugs

Post by pgimeno » Wed Apr 04, 2018 2:59 pm

  • I was taking a look at the source and found this snippet in wrap_Graphics.cpp:

    Code: Select all

    if (targets.colors.back().canvas->getTextureType() != TEXTURE_2D)
      return luaL_error(L, "The table-of-tables variant of setCanvas must be used with non-2D Canvases.");
    
    By my reading, the error message should either be "can't be used with non-2D..." or "must be used with 2D...".

  • love.image.newImageData(1, 1, 'abcd') worked in 0.10 (creating an rgba8 image with the given data); in 11.0 it's triggering "Invalid pixel format: abcd" - however love.image.newImageData(1, 1, 'rgba8', 'abcd') works as expected. Is that just a documentation issue? Or was the intention to default to 'rgba8' like 0.10 did, when using a 3-parameter version?
Thrust II Reloaded - GifLoad for Löve - GSpöt GUI - My NotABug.org repositories
The Microsoft Github repositories I had have been closed after the acquisition announcement and will be removed in the near future.

User avatar
slime
Solid Snayke
Posts: 2763
Joined: Mon Aug 23, 2010 6:45 am
Location: Nova Scotia, Canada
Contact:

Re: 11.0 bugs

Post by slime » Wed Apr 04, 2018 4:16 pm

pgimeno wrote:
Wed Apr 04, 2018 2:59 pm
By my reading, the error message should either be "can't be used with non-2D..." or "must be used with 2D...".
The error is trying to say that non-2D canvases must use a different variant of the function than setCanvas(canvas, ...) or setCanvas{canvas, ...} (they must use a new table-of-tables variant).
pgimeno wrote:
Wed Apr 04, 2018 2:59 pm
love.image.newImageData(1, 1, 'abcd') worked in 0.10 (creating an rgba8 image with the given data); in 11.0 it's triggering "Invalid pixel format: abcd" - however love.image.newImageData(1, 1, 'rgba8', 'abcd') works as expected. Is that just a documentation issue?
Yes, the old 3 parameter version is removed. The new function definition is newImageData(width, height [, format [, rawbytes]]) instead of newImageData(width, height [, rawbytes]).

User avatar
Davidobot
Party member
Posts: 1144
Joined: Sat Mar 31, 2012 5:18 am
Location: Game-Dev. Land
Contact:

Re: 11.0 bugs

Post by Davidobot » Wed Apr 04, 2018 4:44 pm

The changelog has the following line:

Code: Select all

Added Shader:send(matrixname, is_column_major, matrix, ...) which specifies how to interpret the matrix table arguments.
But the page for Shader:send only has this version:

Code: Select all

Shader:send( name, data, matrixlayout, offset, size )
Further, changing the matrixlayout between "row" and "column" seems to have no effect.

I also think that the change from matrices being column-major to row-major should be listed in the changelog.
My library:
LovelyMoon

Check out my current project:
Raycaster

Oh hey, I have a website now!

User avatar
pgimeno
Party member
Posts: 1229
Joined: Sun Oct 18, 2015 2:58 pm

Re: 11.0 bugs

Post by pgimeno » Wed Apr 04, 2018 4:53 pm

@slime:

Thanks for the explanation on the error message. It's clear now, though I wonder if it will mislead more people.

About newImageData, I've edited the wiki accordingly. I may have screwed up the order, not sure.

To hopefully prevent it from getting lost in the other thread, and since I can't use the issue tracker submit form in BitBucket, I'll add it here too: when building as static, pthread is missing from the link line.

@Davidobot: Yeah, I was confused by that too. Note that the variant listed in the docs actually requires a Data object, not a table. No idea how to generate that object (maybe from a Transform? but there's no Transform:getData() so no idea), or why it's useful.
Thrust II Reloaded - GifLoad for Löve - GSpöt GUI - My NotABug.org repositories
The Microsoft Github repositories I had have been closed after the acquisition announcement and will be removed in the near future.

User avatar
MarvelME
Prole
Posts: 10
Joined: Wed Oct 26, 2016 4:02 pm
Location: Ukraine
Contact:

Re: 11.0 bugs

Post by MarvelME » Thu Apr 05, 2018 12:28 am

Console stopped working:

Code: Select all

c:\Gamedev\Love\RL2\RL2>"c:\Program Files\LOVE\lovec.exe" c:\Gamedev\Love\RL2\RL2 s
Error: [string "boot.lua"]:385: Could not create console.
stack traceback:
        [string "boot.lua"]:637: in function <[string "boot.lua"]:633>
        [C]: in function '_openConsole'
        [string "boot.lua"]:385: in function <[string "boot.lua"]:311>
        [C]: in function 'xpcall'
        [string "boot.lua"]:645: in function <[string "boot.lua"]:639>
        [C]: in function 'xpcall'

Win10 x64

.. but its not a issue for me, changed lovec to love, ait it just prints to console

User avatar
SiENcE
Party member
Posts: 753
Joined: Thu Jul 24, 2008 2:25 pm
Location: Berlin/Germany
Contact:

Re: 11.0 bugs

Post by SiENcE » Thu Apr 05, 2018 1:26 pm

It's a hard crash.

Samples attached (it's not from me, it was earlier shared in the forum).

When i comment the following line out, everything works.

Code: Select all

shader2 = love.graphics.newShader("shader2.glsl")
Attachments
Shockwave_working_love110.love
(1.1 MiB) Downloaded 27 times
Shockwave.love
(1.1 MiB) Downloaded 29 times
crash_love110.jpg
crash_love110.jpg (39.93 KiB) Viewed 1181 times
Last edited by SiENcE on Thu Apr 05, 2018 1:43 pm, edited 2 times in total.

azoyan
Prole
Posts: 12
Joined: Wed Dec 27, 2017 5:19 pm

Re: 11.0 bugs

Post by azoyan » Thu Apr 05, 2018 1:34 pm

Where is love.audio.setEffect documentation? I see only https://love2d.org/wiki/Source:setEffect documentation.

User avatar
SiENcE
Party member
Posts: 753
Joined: Thu Jul 24, 2008 2:25 pm
Location: Berlin/Germany
Contact:

Re: 11.0 bugs

Post by SiENcE » Thu Apr 05, 2018 1:47 pm

azoyan wrote:
Thu Apr 05, 2018 1:34 pm
Where is love.audio.setEffect documentation? I see only https://love2d.org/wiki/Source:setEffect documentation.
I think it's no bug... but this is all i can find: https://love2d.org/wiki/Effect_Constant ... Candidates

Also: https://love2d.org/irclogs/love-2017-06-21.log

User avatar
zorg
Party member
Posts: 2367
Joined: Thu Dec 13, 2012 2:55 pm
Location: Absurdistan, Hungary
Contact:

Re: 11.0 bugs

Post by zorg » Thu Apr 05, 2018 2:25 pm

azoyan wrote:
Thu Apr 05, 2018 1:34 pm
Where is love.audio.setEffect documentation? I see only https://love2d.org/wiki/Source:setEffect documentation.
Someone still needs to write that for the wiki i guess.
Me and my stuff :3True Neutral Aspirant. Why, yes, i do indeed enjoy sarcastically correcting others when they make the most blatant of spelling mistakes. No bullying or trolling the innocent tho.

User avatar
Ref
Party member
Posts: 672
Joined: Wed May 02, 2012 11:05 pm

Re: 11.0 bugs

Post by Ref » Thu Apr 05, 2018 2:41 pm

Is there no direct way to get imagedata from an image in Love 11?
The only way I've found is to draw the image to a canvas and then get the imagedata from the canvas or to reload the image from a file as imagedata.

Post Reply

Who is online

Users browsing this forum: No registered users and 3 guests