Page 2 of 3

Re: [library] shine - post processing effects for everyone

Posted: Tue Jan 13, 2015 3:37 pm
by zorg
Works for me now, on nvidia.

Although, if i move the gaussian blur shader's slider all the way to the left, it errors with "line 4: undefined variable "nanf"
Probably a div by 0 issue :3

Re: [library] shine - post processing effects for everyone

Posted: Tue Jan 13, 2015 8:33 pm
by davisdude
Nice work!
On the Gaussian blur effect if you move the slider all the way to the left you get the error:
Error

Cannot compile pixel shader code:
Line 2: WARNING: Only GLSL version > 110 allows prefix "F" or "f" for float
Line 3: ERROR: 'nanf' : undeclared identifier
Line 3: WARNING: Only GLSL version > 110 allows prefix "F" or "f" for float
I feel like somebody's already let you know about this error, but oh well.

Re: [library] shine - post processing effects for everyone

Posted: Tue Jan 13, 2015 8:43 pm
by Robin
I'd really like a bloom shader, I've never gotten it to work myself.

Re: [library] shine - post processing effects for everyone

Posted: Tue Jan 13, 2015 9:07 pm
by vrld
Incidentally, I just added a simple bloom effect. I am sure that could be done better (slime...?), but it seems to work.
The updated demo contains a second image where the effect is more visible.

Positive07 also did some efforts to get the shaders to run on android.
After fixing some stuff I got the to run on my phone as well.
There is now also an option to change the grain size in the filmgrain effect.

Any other suggestions/ideas for effects?
I'll try to complete the wiki with information how to write your own effects and how to get them into the repo tomorrow evening.

Re: [library] shine - post processing effects for everyone

Posted: Tue Jan 13, 2015 9:46 pm
by kikito
Hi there,

Congrats on the idea, this looks like a very good initiative.

The demo fails for me in several occasions (I just re-downloaded it again to make sure).
  • When selecting colorgradesimple, I get "quickie/slider.lua:35: Invalid argument. (from main.lua:156)
  • Gaussianblur throws an error if the slider is set to 0: Line 4: ERROR: Use of undeclared identifier 'nan' (from shine/gaussianblur.lua:91: in function 'set')
  • A similar error happens when sigma is set to 0 in simpleglow: Line 4: ERROR: Use of undeclared identifier 'nan' (from shine/simpleglow.lua:104: in function 'set')
vrld wrote:Any other suggestions/ideas for effects?
Too many. :crazy:

Re: [library] shine - post processing effects for everyone

Posted: Tue Jan 13, 2015 10:25 pm
by vrld
kikito wrote:The demo fails for me in several occasions (I just re-downloaded it again to make sure).
Whoops... should be fixed now.
uhm..

Re: [library] shine - post processing effects for everyone

Posted: Tue Jan 13, 2015 10:33 pm
by undef
vrld wrote: Any other suggestions/ideas for effects?
I'd love to see a dilate and an erode shader :)

Really like the effects in this video:


Re: [library] shine - post processing effects for everyone

Posted: Wed Jan 14, 2015 1:53 am
by zorg
A new error! Again when setting gaussian blur's variable to 0.
shine/gaussianblur.lua:75: Variable 'direction' does not exist.
A common error is to define but not use the variable.

Also same error with glowsimple, on glowsimple.lua:87

Re: [library] shine - post processing effects for everyone

Posted: Wed Jan 14, 2015 3:58 am
by Foxcraft
Awesome work, vrid! :awesome: Very cool.

Re: [library] shine - post processing effects for everyone

Posted: Sun Mar 01, 2015 7:21 am
by dizzykiwi3
This is AMAZING.
Do you know if it works with cameras and scissors? I seem to be having troubles with it, and I'm not sure if its because of my misuse of it or incompatibility with those.