Freeze when running on iOS

[slmjkdbtl]

Hi! I'm new to love2d and lua, I'm not sure if this piece of code is written in best practice because sometime it causes my phone to freeze when running the function. (the code is just to generate a new coordinate of 'food')

Is there anything wrong with the looping?

Code: Select all

function food.update()

	local rand = love.math.random

	x = rand(field.innerX + food.width * 2, field.innerX + field.innerWidth - food.width * 3)
	y = rand(field.innerY + food.height * 2, field.innerY + field.innerHeight - food.height * 3)

	while (x >= snave.x - snave.width * 2 and
		   x <= snave.x + snave.width * 3 and
		   y >= snave.y - snave.height * 2 and
		   y <= snave.y + snave.height * 3) do

		x = rand(field.innerX + food.width * 2, field.innerX + field.innerWidth - food.width * 3)
		y = rand(field.innerY + food.height * 2, field.innerY + field.innerHeight - food.height * 3)	

	end

	food.x = x
	food.y = y

end

[raidho36]

See if the boundary of generated coordinates can be reached by the function you're using. If not, it will never generate valid coordinates and will loop forever.

[zorg]

I'm pretty sure that you can optimize that loop out into simpler min/max operations:

Code: Select all

function food.update()

	local rand = love.math.random

	local xmin = math.max(snave.x + snave.width * 3, field.innerX + food.width * 2)
	local xmax = math.min(snave.x - snave.width * 2, field.innerX + field.innerWidth - food.width * 3)

	local ymin = math.max(snave.y + snave.height * 3, field.innerY + food.height * 2)
	local ymax = math.min(snave.y - snave.height * 2, field.innerY + field.innerHeight - food.height * 3)

	food.x = rand(xmin, xmax)
	food.y = rand(ymin, ymax)

end

This is basically what you want to do, based on the code; check whether it makes sense for you, and if not, maybe you'll find your issue easier like this.

[slmjkdbtl]

See if the boundary of generated coordinates can be reached by the function you're using. If not, it will never generate valid coordinates and will loop forever.

It could be reached and it runs normally on macOS

[raidho36]

Well then it could be that it takes very long time on your phone, there's no JIT compilation enabled and it's not very fast to start with, too.