Page 1 of 1

Is asking for code review here in bad taste?

Posted: Fri May 18, 2018 4:18 pm
by lazershark3k
Hey, I'm working on a game, and I was thinking it would be nice to have some extra eyeballs on it. Would it be ok to ask for a review here? If this isn't the best spot, do you have any recommendations? thx m8s

Re: Is asking for code review here in bad taste?

Posted: Fri May 18, 2018 5:46 pm
by DekuJuice
I'd say it depends on how much code you want looked at. If there's specific sections or issues you want looked at I'm sure people here would be willing to help, but asking to look over all of your code is probably a little too much for most.

Re: Is asking for code review here in bad taste?

Posted: Fri May 18, 2018 6:25 pm
by NotARaptor
Post it and see!

Re: Is asking for code review here in bad taste?

Posted: Fri May 18, 2018 6:29 pm
by D0NM
Some kind of this forums people do review tiny pieces of code constantly.

I have eons of mah Zabuyaki code. I'd like to ask people review it ))) but... it looks like an impossible task.
Pay people and get your code reviewed.

And here is another solution:
Make your game open source. Let people in.

Re: Is asking for code review here in bad taste?

Posted: Fri May 18, 2018 7:00 pm
by Stifu
D0NM wrote: Fri May 18, 2018 6:29 pm And here is another solution:
Make your game open source. Let people in.
Well, that goes without saying. But as DekuJuice said, you should ask reviewers to focus on a specific part, or no one will do it.

Re: Is asking for code review here in bad taste?

Posted: Fri May 18, 2018 10:27 pm
by lazershark3k
Thanks, mates. I appreciate the perspective

Re: Is asking for code review here in bad taste?

Posted: Sat May 19, 2018 6:48 am
by grump
I privately asked two experienced forum members for a review of ~200 LOC, and was pleasantly surprised by their willingness to help. They provided mostly suggestions to improve performance, semantics and style. Some bugs were missed by them, but that's understandable - a thorough code review takes time and very few are willing to 'waste' their time just as a favor for some schmuck on the Internet. In my case their feedback was nevertheless valuable and helped me improve code quality.

If the code is not too large and convoluted, I'm willing to do quick reviews and give general advice when I have time, just shoot me a PM.