[fixed] setKeyRepeat + toggleFullscreen issue

[Saegor]

hello

when i use love.graphics.toggleFullscreen(), it deactivates keyboard.setKeyRepeat(). i WONDER why !

here is a quick test code :

Code: Select all

function love.load()

	x = 0

	love.keyboard.setKeyRepeat(.1, .1)
--	love.graphics.toggleFullscreen()
end

function love.draw()

	love.graphics.print(x, 0, 0)
end

function love.keypressed(key)

	if key == " " then x = x + 1 end
	if key == "escape" then love.event.quit() end
end

it draw a number that increase when space is pressed
hold space and number go to the sky
but if you edit the code to uncomment the fifth line, the setRepeatKey function will go back to default values

[bartbes]

Just fixed, should be in 0.8.1.

[miko]

hello

when i use love.graphics.toggleFullscreen(), it deactivates keyboard.setKeyRepeat(). i WONDER why !

I bet because SDL uses 2 different APIs: X11 in case of windowed mode (assuming you are on linux), and console (or more direct access, bypassing X11 layer) in case of fullscreen mode. If you want it to work, switch the lines: first set the mode (fullscreen), then set the key repetition.
Anyways, you may want to use isDown() with a timer within love.update() instead.

[Saegor]

thanks miko, thanks bartbes !

[bartbes]

What miko said is actually wrong, it's simply because the window is recreated, which means most/all settings on it are lost, I just added some code to pull the current keyrepeat settings before executing the internal version of setMode, then restoring them afterwards.

EDIT: For all setModes, btw, not just toggleFullscreen.

[miko]

What miko said is actually wrong, it's simply because the window is recreated

Oh, good to know. I should have checked out the source code first