Is asking for code review here in bad taste?

Questions about the LÖVE API, installing LÖVE and other support related questions go here.
Forum rules
Before you make a thread asking for help, read this.
Post Reply
User avatar
lazershark3k
Prole
Posts: 17
Joined: Tue Apr 10, 2018 3:20 pm

Is asking for code review here in bad taste?

Post by lazershark3k » Fri May 18, 2018 4:18 pm

Hey, I'm working on a game, and I was thinking it would be nice to have some extra eyeballs on it. Would it be ok to ask for a review here? If this isn't the best spot, do you have any recommendations? thx m8s
*pew pew*

User avatar
DekuJuice
Prole
Posts: 14
Joined: Mon Nov 24, 2014 9:31 pm

Re: Is asking for code review here in bad taste?

Post by DekuJuice » Fri May 18, 2018 5:46 pm

I'd say it depends on how much code you want looked at. If there's specific sections or issues you want looked at I'm sure people here would be willing to help, but asking to look over all of your code is probably a little too much for most.

User avatar
NotARaptor
Citizen
Posts: 59
Joined: Thu Feb 22, 2018 3:15 pm

Re: Is asking for code review here in bad taste?

Post by NotARaptor » Fri May 18, 2018 6:25 pm

Post it and see!

User avatar
D0NM
Party member
Posts: 221
Joined: Mon Feb 08, 2016 10:35 am
Location: Zabuyaki
Contact:

Re: Is asking for code review here in bad taste?

Post by D0NM » Fri May 18, 2018 6:29 pm

Some kind of this forums people do review tiny pieces of code constantly.

I have eons of mah Zabuyaki code. I'd like to ask people review it ))) but... it looks like an impossible task.
Pay people and get your code reviewed.

And here is another solution:
Make your game open source. Let people in.
Our LÖVE Gamedev blog Zabuyaki (an open source retro beat 'em up game). Follow @Zabuyaki.
Twitter @FaMeSoft / GP32 Free Platformer: SUPER PLUSHA
:joker: LÖVE & Lua Video Lessons in Russian / Видео уроки по LÖVE и Lua :joker:

User avatar
Stifu
Citizen
Posts: 73
Joined: Mon Mar 14, 2016 9:53 am
Contact:

Re: Is asking for code review here in bad taste?

Post by Stifu » Fri May 18, 2018 7:00 pm

D0NM wrote:
Fri May 18, 2018 6:29 pm
And here is another solution:
Make your game open source. Let people in.
Well, that goes without saying. But as DekuJuice said, you should ask reviewers to focus on a specific part, or no one will do it.
Zabuyaki, our upcoming beat 'em up: https://www.zabuyaki.com

User avatar
lazershark3k
Prole
Posts: 17
Joined: Tue Apr 10, 2018 3:20 pm

Re: Is asking for code review here in bad taste?

Post by lazershark3k » Fri May 18, 2018 10:27 pm

Thanks, mates. I appreciate the perspective
*pew pew*

grump
Party member
Posts: 587
Joined: Sat Jul 22, 2017 7:43 pm

Re: Is asking for code review here in bad taste?

Post by grump » Sat May 19, 2018 6:48 am

I privately asked two experienced forum members for a review of ~200 LOC, and was pleasantly surprised by their willingness to help. They provided mostly suggestions to improve performance, semantics and style. Some bugs were missed by them, but that's understandable - a thorough code review takes time and very few are willing to 'waste' their time just as a favor for some schmuck on the Internet. In my case their feedback was nevertheless valuable and helped me improve code quality.

If the code is not too large and convoluted, I'm willing to do quick reviews and give general advice when I have time, just shoot me a PM.

Post Reply

Who is online

Users browsing this forum: No registered users and 14 guests