save lua-table to lua-script

[Centauri Soldier]

At a glance, your serialize function fails to save boolean values correctly. tostring() on a boolean value will return 0 or 1, not "true" or "false".

[DaedalusYoung]

Tostring returns true and false on my booleans. It can't return 0 or 1, because 0 is not false.

[Robin]

I'm not sure the way it deals with types it doesn't recognise in a useful manner. It would be better to throw an error in that case, IMO, than just wait to have it blow up at deserialising time.

Also, it doesn't deal with cycle, so

Code: Select all

local T = {}
T.ref = T
serialize(T)

will cause an infinite loop.

[xXxMoNkEyMaNxXx]

it doesn't deal with cycle, so

Code: Select all

local T = {}
T.ref = T
serialize(T)

will cause an infinite loop.

Yikes! I didn't think of that.

At a glance, your serialize function fails to save boolean values correctly. tostring() on a boolean value will return 0 or 1, not "true" or "false".

This is incorrect. Try it.

[Robin]

it doesn't deal with cycle, so

Code: Select all

local T = {}
T.ref = T
serialize(T)

will cause an infinite loop.

Yikes! I didn't think of that.

It's not necessarily problematic. You just have to make sure you only need to serialize acyclic values. If it's intended to be a general use library, make sure you clearly advertise the fact that it doesn't handle cycles.

[Centauri Soldier]

This is incorrect. Try it.

Weird, in my other IDE it returns 0 and 1.

[xXxMoNkEyMaNxXx]

Weird, in my other IDE it returns 0 and 1.

Which one? It should never do that in Lua, unless the tostring function is replaced.

[raidho36]

I guess that's another reason why IDEs are bad.

[Centauri Soldier]

Yeah, it uses it's own version of lua.